Skip to content

The highly dreaded roles rename [INCOMPLETE]#7

Closed
Monotheonist wants to merge 19 commits into
emberfall-14:masterfrom
Monotheonist:roles
Closed

The highly dreaded roles rename [INCOMPLETE]#7
Monotheonist wants to merge 19 commits into
emberfall-14:masterfrom
Monotheonist:roles

Conversation

@Monotheonist

Copy link
Copy Markdown
Contributor

About the PR

Renamed the things that are outlined as having different names in The Station.

Why / Balance

Because lore 😎

Technical details

Does the following:

  • Edits upstream YAML for at least a few lines. I'm probably missing some. If you catch it, let me know.
  • Touches upstream locale files because the VSCode fluent extension fucking shat itself.
  • Overrides a lot of the item of the locale for Captain, HoP, Detective, and Chemist (which I barely touched because I'm asking myself if I really wanna do Chemistry -> Pharmacy (and so is Milon apparently.) If I missed things, PR it, it's really a bang up job. There will be mistakes.
  • Adds access localizations for this
  • Adds job name and timer locale
  • Adds supervisor name changes
  • Adds custom descriptions for at least too jobs.
    Holy fuck, it's all Fluent! So much fucking FLUENT!! AAAAAAAAAAAAAAAAAAAAAAAAAAA!!!

Media

  • I have added media to this PR or it does not require an ingame showcase. (It works properly. That's all you need to know)

@Monotheonist Monotheonist requested review from a team as code owners December 28, 2024 21:59
@github-actions github-actions Bot added size/M 100-999 lines S: Needs Review Changes: YML Changes any yml files Changes: Localization Changes any ftl files and removed S: Needs Review labels Dec 28, 2024
@Monotheonist

Copy link
Copy Markdown
Contributor Author

(I forgot the play-time trackers, so don't merge this.)

@MilonPL MilonPL left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(there were in fact more items mentioning the detective)

Comment thread Resources/Locale/en-US/emberfall/job/job-item-overrides.ftl
Comment thread Resources/Locale/en-US/devices/device-network.ftl
Comment thread Resources/Locale/en-US/devices/device-network.ftl
Comment thread Resources/Locale/en-US/game-ticking/game-rules/gamerule-admin.ftl
Comment thread Resources/Locale/en-US/revenant/revenant.ftl
Comment thread Resources/Locale/en-US/weapons/melee/melee.ftl
@Monotheonist

Copy link
Copy Markdown
Contributor Author

Once again I am realistically forgetting a lot of items (I have to address figurines at some point.)

@Monotheonist

Copy link
Copy Markdown
Contributor Author

How I feel after getting past the goddamn yaml linter
image

@Monotheonist Monotheonist requested a review from MilonPL December 29, 2024 06:43
@github-actions

github-actions Bot commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions Bot added the S: Merge Conflict Fix your PR! label Jan 7, 2025
@MilonPL

MilonPL commented Jan 7, 2025

Copy link
Copy Markdown
Collaborator

damnation

MilonPL pushed a commit that referenced this pull request Jan 19, 2025
* Make important change (#7)

This is to help julian test his bot

* Omnibus

* Remove random test file from testing a gh bot

* Add pin to vendor, spawners and loadout

---------

Co-authored-by: nikthechampiongr <32041239+nikthechampiongr@users.noreply.github.com>
(cherry picked from commit a967fc748613fd34a9f6144ef6f702e30fb4f1a8)
@Monotheonist Monotheonist changed the title The highly dreaded roles rename The highly dreaded roles rename [INCOMPLETE] May 23, 2025
@github-actions github-actions Bot removed the S: Merge Conflict Fix your PR! label May 23, 2025
@Monotheonist

Copy link
Copy Markdown
Contributor Author

Milon, we both know this is gonna take forever so feel free to merge this at any point considering it's at least a start, I fixed the conflicts with CSS.

@Monotheonist

Copy link
Copy Markdown
Contributor Author

FUCK!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review size/M 100-999 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants